Skip to content

[WIP][FG:InPlacePodVerticalScaling] Consider exist CPU in topology manager when pod resize #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chunxia202410 wants to merge 9 commits into
base: policy_static
Choose a base branch
from
Open

[WIP][FG:InPlacePodVerticalScaling] Consider exist CPU in topology manager when pod resize #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
643f058
Static CPU management policy alongside InPlacePodVerticalScaling
esotsal Jan 20, 2025
7349606
Support InPlacePodVerticalScaling for Static CPU management policy
Chunxia202410 Feb 21, 2025
2d2c8a3
Fix go fmt isssues
esotsal Feb 21, 2025
b5daaf9
Fix mutation heuristic check of mustKeepCPUs, reason is clone
esotsal Feb 22, 2025
968d584
Fix glangci-lint-pr failed test
esotsal Mar 3, 2025
e94a026
Fix compile issue, due to update in e2e/framework removing rollback bool
esotsal Mar 12, 2025
616ad16
Fix compile issue and address review comment.
esotsal Mar 17, 2025
adaf88a
Address sig-node meeting comments for mustKeepCPUs.
esotsal Mar 28, 2025
2c78b16
consider exist CPU in topology manager when pod resize.
Chunxia202410 Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions hack/local-up-cluster.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ KUBELET_PROVIDER_ID=${KUBELET_PROVIDER_ID:-"$(hostname)"}
FEATURE_GATES=${FEATURE_GATES:-"AllAlpha=false"}
EMULATED_VERSION=${EMULATED_VERSION:+kube=$EMULATED_VERSION}
TOPOLOGY_MANAGER_POLICY=${TOPOLOGY_MANAGER_POLICY:-""}
MEMORY_MANAGER_POLICY=${MEMORY_MANAGER_POLICY:-""}
CPUMANAGER_POLICY=${CPUMANAGER_POLICY:-""}
CPUMANAGER_RECONCILE_PERIOD=${CPUMANAGER_RECONCILE_PERIOD:-""}
CPUMANAGER_POLICY_OPTIONS=${CPUMANAGER_POLICY_OPTIONS:-""}
Expand Down Expand Up @@ -181,6 +182,15 @@ function usage {
echo " CPUMANAGER_RECONCILE_PERIOD=\"5s\" \\"
echo " KUBELET_FLAGS=\"--kube-reserved=cpu=1,memory=2Gi,ephemeral-storage=1Gi --system-reserved=cpu=1,memory=2Gi,ephemeral-storage=1Gi\" \\"
echo " hack/local-up-cluster.sh (build a local copy of the source with full-pcpus-only CPU Management policy)"
echo "Example 5: PATH=\"\${PATH}:/usr/local/go/src/k8s.io/kubernetes/third_party/etcd\" \\"
echo " FEATURE_GATES=CPUManagerPolicyOptions=true,MemoryManager=true,InPlacePodVerticalScalingExclusiveCPUs=true \\"
echo " TOPOLOGY_MANAGER_POLICY=\"single-numa-node\" \\"
echo " MEMORY_MANAGER_POLICY=\"Static\" \\"
echo " CPUMANAGER_POLICY=\"static\" \\"
echo " CPUMANAGER_POLICY_OPTIONS=full-pcpus-only=\"true\" \\"
echo " CPUMANAGER_RECONCILE_PERIOD=\"5s\" \\"
echo " KUBELET_FLAGS=\"--kube-reserved=cpu=1,memory=4Gi --system-reserved=cpu=1,memory=1Gi --reserved-memory 0:memory=3Gi;1:memory=2148Mi --resolv-conf=/run/systemd/resolve/resolv.conf\" \\"
echo " hack/local-up-cluster.sh ( run with Topology, CPU, Memory Management policies alongside InPlacePodVerticalScaling, extra flags for etcd and coredns)"
echo ""
echo "-d dry-run: prepare for running commands, then show their command lines instead of running them"
}
Expand Down Expand Up @@ -1000,6 +1010,11 @@ EOF
echo "topologyManagerPolicy: \"${TOPOLOGY_MANAGER_POLICY}\""
fi

# memorymanager policy
if [[ -n ${MEMORY_MANAGER_POLICY} ]]; then
echo "memoryManagerPolicy: \"${MEMORY_MANAGER_POLICY}\""
fi

# cpumanager policy
if [[ -n ${CPUMANAGER_POLICY} ]]; then
echo "cpuManagerPolicy: \"${CPUMANAGER_POLICY}\""
Expand Down
438 changes: 423 additions & 15 deletions pkg/kubelet/cm/cpumanager/cpu_assignment.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading