added https, a new port and catch exceptions more broadly#122
Open
FieserKiller wants to merge 1 commit intoeslavnov:masterfrom
Open
added https, a new port and catch exceptions more broadly#122FieserKiller wants to merge 1 commit intoeslavnov:masterfrom
FieserKiller wants to merge 1 commit intoeslavnov:masterfrom
Conversation
My TV's (55PML9507) jointSPACE endpoint is https and on port 1926 so I made find_api_version() find it. Exceptions are catched more broadly because both json parser and requests lib threw multiple exceptions on discovery which are all catched now.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My TV's (55PML9507) jointSPACE endpoint is https and on port 1926 so I made find_api_version() find it. Exceptions are catched more broadly because both json parser and requests lib threw multiple exceptions while in discovery (socket timeouts, json not parseable, etc.) which are all catched now.