Open
Conversation
MatsK
reviewed
Sep 21, 2021
MatsK
left a comment
MatsK
left a comment
There was a problem hiding this comment.
I miss a section in README.md that covers the initial pairing of TV and pylips container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
to let pylips run continously (to provide the API via MQTT) I dockerized the application.
The docker image is based on the slim python image, resulting in an overall image of only ~140MB (on x64/Linux).
If you want to offer the docker image also on dockerhub, I'd be happy to create a pull-request that uses GitHub actions to automatically build and publish a multi-platform image. Just let me know ;)