Make overwriting / updating vm.args and app.config optional#51
Open
adamramage wants to merge 1 commit intoesl:masterfrom
Open
Make overwriting / updating vm.args and app.config optional#51adamramage wants to merge 1 commit intoesl:masterfrom
adamramage wants to merge 1 commit intoesl:masterfrom
Conversation
Member
|
Thanks @adamramage for your contribution. Could you provide more information about the need for this change? The files are updated to keep them in sync with the environment variables, and I would like to know the reasoning behind skipping this step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extreme cases require the vm.args and app.config files to not be modified as part of the start up.
change adds an option via envs to disable the script from making such changes. default is to update/modify files.