Skip to content

Make JOIN_CLUSTER disabled by default#4617

Merged
chrzaszcz merged 2 commits intomasterfrom
cets-default
Jan 13, 2026
Merged

Make JOIN_CLUSTER disabled by default#4617
chrzaszcz merged 2 commits intomasterfrom
cets-default

Conversation

@kamilwaz
Copy link
Contributor

@kamilwaz kamilwaz commented Jan 9, 2026

The goal of this PR is to set the default value of the JOIN_CLUSTER variable to false. This variable is used only with Mnesia, which we recommend replacing with CETS.

⚓︎ #4617, esl/MongooseHelm#59, esl/mongooseim-docker#61

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 9, 2026

CircleCI results for 6ff4867

elasticsearch_and_cassandra_28 / elasticsearch_and_cassandra_mnesia / 6ff4867
Reports root/ big
OK: 683 / Failed: 0 / User-skipped: 72 / Auto-skipped: 0

small_tests_27 / small_tests / 6ff4867
Reports root / small

small_tests_28 / small_tests / 6ff4867
Reports root / small

small_tests_28_arm64 / small_tests / 6ff4867
Reports root / small

ldap_mnesia_27 / ldap_mnesia / 6ff4867
Reports root/ big
OK: 2358 / Failed: 0 / User-skipped: 1378 / Auto-skipped: 0

ldap_mnesia_28 / ldap_mnesia / 6ff4867
Reports root/ big
OK: 2358 / Failed: 0 / User-skipped: 1378 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_28 / pgsql_mnesia / 6ff4867
Reports root/ big
OK: 5233 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

dynamic_domains_mysql_redis_28 / mysql_redis / 6ff4867
Reports root/ big
OK: 5198 / Failed: 0 / User-skipped: 157 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 6ff4867
Reports root/ big
OK: 5233 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

pgsql_cets_28 / pgsql_cets / 6ff4867
Reports root/ big
OK: 5323 / Failed: 0 / User-skipped: 202 / Auto-skipped: 0

pgsql_mnesia_27 / pgsql_mnesia / 6ff4867
Reports root/ big
OK: 5626 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

cockroachdb_cets_28 / cockroachdb_cets / 6ff4867
Reports root/ big
OK: 5337 / Failed: 7 / User-skipped: 202 / Auto-skipped: 0

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3689@localhost/res1">>,
          escalus_tcp,<0.115573.0>,
          [{event_manager,<0.115562.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3689">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.115562.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3689">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3689">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3689">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"306dd52a570e2f7c">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,444}]},
     {pubsub_tools,receive_and_c...

Report log

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3693@localhost/res1">>,
          escalus_tcp,<0.115650.0>,
          [{event_manager,<0.115648.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3693">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.115648.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3693">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3693">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3693">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"0b5352ffda5d70b8">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,444}]},
     {pubsub_tools,receive_and_c...

Report log

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3696@localhost/res1">>,
          escalus_tcp,<0.115728.0>,
          [{event_manager,<0.115725.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3696">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.115725.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3696">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3696">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3696">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"9854ffc36710e001">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,444}]},
     {pubsub_tools,receive_and_c...

Report log

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3698@localhost/res1">>,
          escalus_tcp,<0.115805.0>,
          [{event_manager,<0.115793.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3698">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.115793.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3698">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3698">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3698">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"05e98f12a534d934">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,444}]},
     {pubsub_tools,receive_and_c...

Report log

pubsub_SUITE:tree+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3752@localhost/res1">>,
          escalus_tcp,<0.117088.0>,
          [{event_manager,<0.117069.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3752">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.117069.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3752">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3752">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3752">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"a7b614a200087385">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,444}]},
     {pubsub_tools,receive_and_c...

Report log

pubsub_SUITE:tree+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3756@localhost/res1">>,
          escalus_tcp,<0.117167.0>,
          [{event_manager,<0.117154.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3756">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.117154.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3756">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3756">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3756">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"53ef903a86038cbc">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,444}]},
     {pubsub_tools,receive_and_c...

Report log

pubsub_SUITE:tree+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3760@localhost/res1">>,
          escalus_tcp,<0.117242.0>,
          [{event_manager,<0.117240.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3760">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.117240.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3760">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3760">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3760">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"5d0fc9100856f84a">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,444}]},
     {pubsub_tools,receive_and_c...

Report log

pgsql_mnesia_28 / pgsql_mnesia / 6ff4867
Reports root/ big
OK: 5626 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

mysql_redis_28 / mysql_redis / 6ff4867
Reports root/ big
OK: 5619 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0

internal_mnesia_28 / internal_mnesia / 6ff4867
Reports root/ big
OK: 2506 / Failed: 0 / User-skipped: 1230 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (1def664) to head (8426435).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4617   +/-   ##
=======================================
  Coverage   86.06%   86.07%           
=======================================
  Files         563      563           
  Lines       33747    33747           
=======================================
+ Hits        29045    29048    +3     
+ Misses       4702     4699    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 12, 2026

CircleCI results for 6937b66

internal_mnesia_28 / internal_mnesia / 6937b66
Reports root/ big
OK: 2506 / Failed: 0 / User-skipped: 1230 / Auto-skipped: 0

elasticsearch_and_cassandra_28 / elasticsearch_and_cassandra_mnesia / 6937b66
Reports root/ big
OK: 683 / Failed: 0 / User-skipped: 72 / Auto-skipped: 0

small_tests_27 / small_tests / 6937b66
Reports root / small

small_tests_28 / small_tests / 6937b66
Reports root / small

small_tests_28_arm64 / small_tests / 6937b66
Reports root / small

ldap_mnesia_27 / ldap_mnesia / 6937b66
Reports root/ big
OK: 2358 / Failed: 0 / User-skipped: 1378 / Auto-skipped: 0

ldap_mnesia_28 / ldap_mnesia / 6937b66
Reports root/ big
OK: 2358 / Failed: 0 / User-skipped: 1378 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_28 / pgsql_mnesia / 6937b66
Reports root/ big
OK: 5233 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

dynamic_domains_mysql_redis_28 / mysql_redis / 6937b66
Reports root/ big
OK: 5198 / Failed: 0 / User-skipped: 157 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 6937b66
Reports root/ big
OK: 5233 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

pgsql_cets_28 / pgsql_cets / 6937b66
Reports root/ big
OK: 5323 / Failed: 0 / User-skipped: 202 / Auto-skipped: 0

mysql_redis_28 / mysql_redis / 6937b66
Reports root/ big
OK: 5619 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0

pgsql_mnesia_27 / pgsql_mnesia / 6937b66
Reports root/ big
OK: 5626 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

pgsql_mnesia_28 / pgsql_mnesia / 6937b66
Reports root/ big
OK: 5626 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

cockroachdb_cets_28 / cockroachdb_cets / 6937b66
Reports root/ big
OK: 5325 / Failed: 1 / User-skipped: 202 / Auto-skipped: 0

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3723@localhost/res1">>,
          escalus_tcp,<0.115757.0>,
          [{event_manager,<0.115756.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3723">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.115756.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3723">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3723">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3723">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"b7c906a6f5925d2a">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,444}]},
     {pubsub_tools,receive_and_c...

Report log

@kamilwaz kamilwaz marked this pull request as ready for review January 12, 2026 11:37
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 13, 2026

CircleCI results for 8426435

elasticsearch_and_cassandra_28 / elasticsearch_and_cassandra_mnesia / 8426435
Reports root/ big
OK: 683 / Failed: 0 / User-skipped: 72 / Auto-skipped: 0

small_tests_27 / small_tests / 8426435
Reports root / small

small_tests_28 / small_tests / 8426435
Reports root / small

small_tests_28_arm64 / small_tests / 8426435
Reports root / small

ldap_mnesia_27 / ldap_mnesia / 8426435
Reports root/ big
OK: 2358 / Failed: 0 / User-skipped: 1378 / Auto-skipped: 0

ldap_mnesia_28 / ldap_mnesia / 8426435
Reports root/ big
OK: 2358 / Failed: 0 / User-skipped: 1378 / Auto-skipped: 0

dynamic_domains_mysql_redis_28 / mysql_redis / 8426435
Reports root/ big
OK: 5198 / Failed: 0 / User-skipped: 157 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_28 / pgsql_mnesia / 8426435
Reports root/ big
OK: 5233 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

internal_mnesia_28 / internal_mnesia / 8426435
Reports root/ big
OK: 2506 / Failed: 0 / User-skipped: 1230 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 8426435
Reports root/ big
OK: 5233 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

pgsql_cets_28 / pgsql_cets / 8426435
Reports root/ big
OK: 5323 / Failed: 0 / User-skipped: 202 / Auto-skipped: 0

cockroachdb_cets_28 / cockroachdb_cets / 8426435
Reports root/ big
OK: 5323 / Failed: 0 / User-skipped: 202 / Auto-skipped: 0

pgsql_mnesia_27 / pgsql_mnesia / 8426435
Reports root/ big
OK: 5626 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

mysql_redis_28 / mysql_redis / 8426435
Reports root/ big
OK: 274 / Failed: 0 / User-skipped: 16 / Auto-skipped: 0

pgsql_mnesia_28 / pgsql_mnesia / 8426435
Reports root/ big
OK: 5626 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@chrzaszcz chrzaszcz merged commit 2925da8 into master Jan 13, 2026
4 checks passed
@chrzaszcz chrzaszcz deleted the cets-default branch January 13, 2026 16:54
@chrzaszcz chrzaszcz added this to the 6.6.0 milestone Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants