Derived.pm: fix spelling in comment #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@eserte I'd like to pick your brain regarding the code just below this comment. What would be a good venue to do so? Tcl::pTk borrows this code, however the hardcoded default colors cause an appearance issue at least on macOS aqua: https://rt.cpan.org/Ticket/Display.html?id=125049. I have not figured out how to resolve this issue, but I imagine I do not understand the purpose of this code very well. Would it be possible to have it leave the colors unset, letting the window manager use default colors? Do Perl/Tk programs depend on these defaults being set? (Edit: see #52) |
Owner
|
I also have to dig deeper into this code and the purpose for it, but I vaguely remember that there were both benefits and downsides doing this bg/fg propagation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.