refactor: value object pattern for Role, FinishReason, SourceType, and time triggers#159
Merged
refactor: value object pattern for Role, FinishReason, SourceType, and time triggers#159
Conversation
Replace raw string literals for message roles, finish reasons, and memory source types with StrEnum value objects. Convert role-dispatch if/elif chains to match/case in LLM provider message conversion.
Replace raw string parsing for time triggers with typed value objects that own their validation and parsing. TimeTrigger fields coerce from strings in __post_init__, eliminating repeated re-parsing in compute_next_schedule and compute_next_interval. Remove dead parse_days/validate_days/resolve_days wrappers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Role,FinishReason,SourceTypeStrEnums inllm/types.pyandmemory/models.py— replace raw string literals across 33 filesTimeOfDay,Interval,DaySpecfrozen dataclasses inautomation/triggers.py— replace repeated string parsing for time trigger fieldsparse_days/validate_days/resolve_dayswrappers