feat: typescript rewrite & add support for esm #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esatterwhite
reviewed
Aug 4, 2025
| "files": [ | ||
| "index.js", | ||
| "lib/", | ||
| "dist/", |
Owner
There was a problem hiding this comment.
You can add dist, but do not remove lib
Author
There was a problem hiding this comment.
the output will be dist because of the tsc, this will be changed later
esatterwhite
reviewed
Aug 4, 2025
| "version": "16.0.0", | ||
| "description": "Object oriented, flexible CLI tools", | ||
| "main": "index.js", | ||
| "main": "dist/index.js", |
Owner
There was a problem hiding this comment.
There is no dist directory in this package.
To be clear, I'm not interested in migrating this project to typescript. You are, however, welcome to contribute type definitions.
I also believe that a complete re-write to esm deserves a discussion and plan around implementation and public interface.
Author
There was a problem hiding this comment.
nah, its fine. we can support both esm & cjs. im looking if the bounty are still relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@algora-pbc /claim #135