Faster EncoderMapper.java #130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
whoops: I do not have the latest WPILIB installed. The message went into my spam folder for some reason. |
Contributor
|
We will look at this after the season. The EncoderMapper has worked for some time so I am not going to change it now based on a very small performance improvement. It is the right longer term thing to do, but not the week before an event. |
Contributor
Author
|
Ok. I realized the problem when I was getting long robot loops becasue I initialized an encoder wrong, but it still shouldn't have happened. I wrote this when we were doing the student code base last year, and tested it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a while loop using math to find the amount of iterations that the previously-while loop would take, and then multiplying that by the distance of one rotation.