Open
Conversation
added 4 commits
June 2, 2020 13:42
- Make sure we compile with and without INVARIANTS in the kernel config. - Properly indent a block. - Make the QUAD sysctls UQUAD as it is uint64_t type members. - Properly hide unused functions behind #if 0 rather than leaving an unused stub with a TODO printf. We can go back to that once we actually call them. - Do export not-really-static functions rather than having static prototypes in other files for them; how did that ever work properly? Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")
Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")
cleanly. Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")
Contributor
Author
|
Hey, you picked the Makefile change out of these changes but most of the others are still not merged and given you moved forward there's some conflicts now. Would you apply them all if I once more make this compile? I'd really like not having to bother about INVARIANTS and WITNESS anymore and being able to compile a GENERIC-NODEBUG without warnings. |
Owner
|
I'm about to cherry pick in the invariants ones, yeah. Sorry, was neck deep
in finishing my own lols. :-)
…-adrian
On Tue, 16 Jun 2020 at 13:35, bzfbd ***@***.***> wrote:
Hey, you picked the Makefile change out of these changes but most of the
others are still not merged and given you moved forward there's some
conflicts now. Would you apply them all if I once more make this compile?
I'd really like not having to bother about INVARIANTS and WITNESS anymore
and being able to compile a GENERIC-NODEBUG without warnings.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#35 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI2L3KL5JILL6ZIZV2YSX3RW7JR5ANCNFSM4NSRBV2A>
.
|
AdSchellevis
added a commit
to AdSchellevis/athp
that referenced
this pull request
Jun 17, 2020
erikarn
force-pushed
the
master
branch
2 times, most recently
from
c55dc6b to
f1c00bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some code cleanup.
Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")