move "batch size estimation" biz-logic from SD to Exec#19011
Open
AskAlexSharov wants to merge 8 commits intomainfrom
Open
move "batch size estimation" biz-logic from SD to Exec#19011AskAlexSharov wants to merge 8 commits intomainfrom
AskAlexSharov wants to merge 8 commits intomainfrom
Conversation
sudeepdino008
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reason:
EstimateSizeit's clearly abstraction-leakBefore this change i see:
but it's not because Commitment producing so much data
it's because we "double-estimate": using estimation logic which "predicting RAM usage after Commitment - before commitment", use same prediction "after Commitment" is incorrect - because "we just know how much RAM we using now".