internal/ethapi: fix error code for revert in simulate#19006
Open
Sahil-4555 wants to merge 2 commits intoerigontech:mainfrom
Open
internal/ethapi: fix error code for revert in simulate#19006Sahil-4555 wants to merge 2 commits intoerigontech:mainfrom
Sahil-4555 wants to merge 2 commits intoerigontech:mainfrom
Conversation
AskAlexSharov
approved these changes
Feb 6, 2026
Contributor
Author
|
still we are using ErrCodeReverted at HandleError and newJsonError feedback on this? |
auto-merge was automatically disabled
February 6, 2026 09:06
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error code for revert should be consistent with eth_call and be 3.
ethereum/execution-apis#748