Skip to content

Add lints for unclosed files and fix numerous lints in tests#18998

Open
anacrolix wants to merge 5 commits intomainfrom
anacrolix/file-and-other-lints
Open

Add lints for unclosed files and fix numerous lints in tests#18998
anacrolix wants to merge 5 commits intomainfrom
anacrolix/file-and-other-lints

Conversation

@anacrolix
Copy link
Contributor

@anacrolix anacrolix commented Feb 6, 2026

Add the temp file lints needed to catch the locked file issue I had on Windows tests here #18197. Also fixes a bunch of other lints that were masked for tests.

@anacrolix anacrolix changed the title Anacrolix/file and other lints Add lints for unclosed files and fix numerous lints in tests Feb 6, 2026
@anacrolix anacrolix enabled auto-merge (squash) February 6, 2026 02:45
@anacrolix anacrolix force-pushed the anacrolix/file-and-other-lints branch from 7cc57ef to 0d1eb84 Compare February 6, 2026 05:24
@anacrolix
Copy link
Contributor Author

Pretty sure the failures are unrelated flakey tests.

@AskAlexSharov
Copy link
Collaborator

Pretty sure the failures are unrelated flakey tests.

but i can reproduce on macbook

@AskAlexSharov
Copy link
Collaborator

commit := func(txn uint64) error {
		err = domains.Flush(ctx, tx)
		require.NoError(t, err)

		err = tx.Commit()
		require.NoError(t, err)

		tx, err = db.BeginTemporalRw(context.Background())
		require.NoError(t, err)
		defer tx.Rollback()

this func is created to create new tx object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants