Add lints for unclosed files and fix numerous lints in tests#18998
Open
Add lints for unclosed files and fix numerous lints in tests#18998
Conversation
AskAlexSharov
approved these changes
Feb 6, 2026
7cc57ef to
0d1eb84
Compare
Contributor
Author
|
Pretty sure the failures are unrelated flakey tests. |
Collaborator
but i can reproduce on macbook |
Collaborator
this func is created to create new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the temp file lints needed to catch the locked file issue I had on Windows tests here #18197. Also fixes a bunch of other lints that were masked for tests.