witness: Fix storage proofs for accounts with no storage#18988
Draft
witness: Fix storage proofs for accounts with no storage#18988
Conversation
AskAlexSharov
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problematic scenario encountered while working on #18290
When requesting proof of a non-existent storage key for an account that has no storage, the traversal does not stop after the account is encountered, and garbage data from the rows in the grid below the account are incorporated into the proof. This ultimately results in incorrect trie root hash.
This problem never surfaced with
eth_getProofcalls because that RPC call has logic to avoid callingGenerateWitnesswhen the account in the account proof has an empty storage root.The fix is to stop the traversal if
len(hashedKey)>64and storage root of account is empty.