Sync p2p code with go-ethereum to fix netrestrict issues in v5 discovery#18933
Open
Sync p2p code with go-ethereum to fix netrestrict issues in v5 discovery#18933
Conversation
taratorio
reviewed
Feb 3, 2026
taratorio
reviewed
Feb 3, 2026
anacrolix
force-pushed
the
anacrolix/netrestrict-p2p-refresh
branch
from
343dfd7 to
7871caf
Compare
anacrolix
force-pushed
the
anacrolix/netrestrict-p2p-refresh
branch
from
d4b07ac to
db09ff4
Compare
anacrolix
requested review from
AskAlexSharov,
Giulio2002,
domiwei,
mh0lt and
yperbasis
as code owners
Collaborator
|
run bench and compare with |
| github.com/edsrzf/mmap-go v1.2.0 | ||
| github.com/elastic/go-freelru v0.16.0 | ||
| github.com/ethereum/go-bigmodexpfix v0.0.0-20250911101455-f9e208c548ab | ||
| github.com/ethereum/go-ethereum v1.16.8 |
Collaborator
There was a problem hiding this comment.
forgot remove this line
go.mod
Outdated
| github.com/quic-go/quic-go v0.49.1 | ||
| github.com/rs/cors v1.11.1 | ||
| github.com/rs/dnscache v0.0.0-20211102005908-e0241e321417 | ||
| github.com/shirou/gopsutil v3.21.11+incompatible |
Collaborator
There was a problem hiding this comment.
i would advise update gopsutil in dedicated PR - because we often reverted it in the past.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18195.
This started as an attempt to carefully pull fixes for possible issues with netrestrict to discovering the upstream changes are quite significant.
Note: This is only a draft. I'm experimenting with Claude for analyzing large diffs at the same time, but all observations are helpful.