Support ! prefix for liquids wherever * prefix is supported
#469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for looking at this. My gut feeling would be to make this HLBSP-only, just in case there are any Quake texture wads with I might push a few docs and tests if that's okay. |
Owner
|
Added a basic test map that checks that we're actually creating CONTENTS_WATER for "!liquidtest" 
|
Owner
|
I think it's fine to merge on my end, if my changes look ok? |
Contributor
Author
|
Looks good. If it works, then go ahead and merge. I had it as draft b/c I hadn't tried compiling yet to make sure it builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #437; required for liquids in GoldSrc to "warp" (where it's used instead of
*).This doesn't do any additional game checking, but I don't think that's a big deal, since ! is unlikely to be used for standard textures anyway.
!support was actually added to Quakespasm about a year ago (in sezero/quakespasm#117 ). If the change in contents proves an issue, an arg could be added to QBSP to disable treating!as liquids.