feat(scanner): country-aware submission quality scoring (#931)

[ericsocrat]

Summary

Closes #931 — Makes Signal 3 (EAN match) in _score_submission_quality country-aware.

Signal 3 Scoring Changes

Scenario	Old Score	New Score	Signal Name
Same-country EAN match	+30	+15	ean_exists_same_country
Cross-country EAN match	+30	+5	ean_exists_other_country
Unknown EAN globally	+0	+0	(none)
NULL country fallback	+30	+15	ean_exists

Key Design Decisions

• Cross-country matches do NOT set v_existing_pid — prevents auto_resolve_existing action from firing when the product only exists in another country
• NULL fallback preserves global behavior — 5-arg callers (backward compat via DEFAULT NULL) get global match at +15
• Old 5-param function explicitly dropped — ensures all calls route through the new 6-param version

Migration

20260321000600_country_aware_quality_scoring.sql:

1. DROP FUNCTION IF EXISTS _score_submission_quality(uuid, text, text, text, text) — removes old overload
2. CREATE OR REPLACE FUNCTION _score_submission_quality(uuid, text, text, text, text, text) — 6-param with country-aware Signal 3
3. score_submission_quality(uuid) — updated to pass v_sub.suggested_country
4. trig_auto_triage_submission() — updated to pass NEW.suggested_country

Tests

6 new pgTAP tests (plan 101 → 107) in scanner_functions.test.sql:

• Same-country EAN match: score = 65, signal = ean_exists_same_country
• Cross-country EAN match: score = 55, signal = ean_exists_other_country
• Unknown EAN globally: score = 50
• NULL country fallback: score = 65

Side effect: Pre-existing test 54 now PASSES (score reduced from 80 → 65, correctly returns manual_review instead of auto_resolve_existing).

Verification

supabase db reset    → migration applies cleanly
supabase test db     → 6/6 new tests pass (107 total)
                       pre-existing failures unchanged (tests 53,55-56 shifted values, still failing)

File Impact

2 files changed, +366 / -1 lines

• 1 new DB migration (293 lines)
• 1 modified pgTAP test file (+73 lines, 6 new tests)

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tryvit	Ready	Preview, Comment	Mar 17, 2026 5:18pm

[Copilot]

Pull request overview

This PR makes scanner submission quality scoring (Signal 3: “EAN matches existing product”) country-aware by adjusting scoring and behavior based on whether the EAN exists in the submission’s suggested country versus only other countries, while preserving a NULL-country fallback for backwards compatibility.

Changes:

• Adds a new migration that updates _score_submission_quality to apply country-aware Signal 3 scoring (+15 same-country, +5 cross-country, +0 unknown; NULL-country fallback uses global match).
• Updates score_submission_quality(uuid) and trig_auto_triage_submission() to pass suggested_country into the scoring helper.
• Extends pgTAP coverage with 6 new tests for the country-aware Signal 3 scenarios and updates the plan count.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
supabase/migrations/20260321000600_country_aware_quality_scoring.sql	Updates the scoring helper + wrapper + trigger to incorporate suggested_country and adjust Signal 3 behavior.
supabase/tests/scanner_functions.test.sql	Adds pgTAP assertions for same-country vs cross-country vs unknown EAN and NULL-country fallback behavior.