material_text_box - new features : allow initial value, disabled, update value and update enable/disable#85
Open
bilbaoba wants to merge 2 commits intoericrayanderson:masterfrom
Open
Conversation
Contributor
Author
|
Hi @ericrayanderson, I test this PR and it's working with the new version of package (v1.0.0). Regards. |
22118ca to
aa113bb
Compare
Contributor
Author
|
Hi @ericrayanderson, I saw you finally set Are you interested by :
If yes, I will correct the conflict. And If not, I will close the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Eric & shinymaterial users,
I propose to answer issue #60 with this PR plus add some new features.
Changes :
value(by default""like into the shiny functionshiny::textInput()) anddisabledinto functionmaterial_text_boxdisabledinto functionupdate_material_text_boxTest :
After install the package :
Best regards.