Modernize shinymaterial package for 2025#136
Open
ericrayanderson wants to merge 2 commits intomasterfrom
Open
Conversation
- Update DESCRIPTION with modern dependencies:
- shiny >= 1.7.0 (was >= 0.7.0)
- Add rlang (>= 1.0.0) and cli for modern error handling
- Add testthat (>= 3.0.0) to Suggests
- Update RoxygenNote to 7.3.2 with markdown support
- Add BugReports URL
- Security improvements:
- Replace eval() with Function() constructor in JS handler
- Add try/catch error handling for safer code execution
- Modernize error handling:
- Replace message("ERROR: ...") with cli::cli_abort()
- Use structured error messages with cli formatting
- Update JavaScript to ES6+ patterns:
- Replace $(document).ready() with DOMContentLoaded
- Use ES6 class syntax for Shiny.InputBinding
- Add 'use strict' and JSDoc comments
- Use const/let instead of var
- Use arrow functions where appropriate
- Remove deprecated code:
- Remove dir_recursion() utility (replaced with dir.create recursive)
- Use built-in dir.create(..., recursive = TRUE)
- Add CI/CD infrastructure:
- Add GitHub Actions R-CMD-check workflow
- Add GitHub Actions test-coverage workflow
- Add testthat testing infrastructure with initial tests
- Update .Rbuildignore for new files
- Update NAMESPACE with cli and rlang imports
Remove extra 'multiple' parameter from Rd file that doesn't exist in the function signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update DESCRIPTION with modern dependencies:
Security improvements:
Modernize error handling:
Update JavaScript to ES6+ patterns:
Remove deprecated code:
Add CI/CD infrastructure:
Update .Rbuildignore for new files
Update NAMESPACE with cli and rlang imports