Handle special characters in Twitter username/password#3
Open
HiroProt wants to merge 1 commit intoericjohnson:masterfrom
Open
Handle special characters in Twitter username/password#3HiroProt wants to merge 1 commit intoericjohnson:masterfrom
HiroProt wants to merge 1 commit intoericjohnson:masterfrom
Conversation
|
This fix a problem I was having. I adapted this library to authenticate with Tumblr (by changing the access_token url) but Tumblr uses emails for usernames. This fixed my problem right up. |
|
Hello malcolmbastien Iam unable to integrate tumblr in my application. can you provide me the sample code? Thanks....... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library doesn't seem to be escaping special characters in username/password for the signature base string, resulting in failure if the user has special characters in his/her password.
I've added the required escapes, and that seems to do the trick.