-
Notifications
You must be signed in to change notification settings - Fork 4
Improved install #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved install #51
Conversation
Add --install top-level flag to perform all install behaviors. Ensure binary is installed into a sensible PATH location.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 86.80% 81.42% -5.38%
==========================================
Files 61 62 +1
Lines 4144 4656 +512
==========================================
+ Hits 3597 3791 +194
- Misses 399 674 +275
- Partials 148 191 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a unified --install flag that streamlines the installation process by installing the dashlights binary to an appropriate PATH location, configuring the shell prompt, and automatically detecting and setting up AI agent hooks for Claude Code and Cursor in a single command.
Key changes:
- Added
--installflag for complete installation (binary + prompt + detected AI agents) - Implemented smart binary installation logic that respects existing locations, skips non-preferred directories, and falls back to
~/.local/binwith automatic PATH configuration - Automatic detection and installation of AI agent hooks when
.claudeor.cursordirectories are present
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.go | Added --install flag and integrated with install mode |
| src/install/templates.go | Added PATH export templates for bash, zsh, and fish shells |
| src/install/install.go | Implemented unified install orchestration with component detection and installation |
| src/install/filesystem.go | Extended filesystem interface with binary-related operations (copy, chmod, symlink detection, PATH parsing) |
| src/install/binary.go | New binary installer with smart PATH directory selection and version comparison |
| src/install/binary_test.go | Comprehensive test coverage for binary installation scenarios |
| scripts/dockerized-install-test.sh | Added integration tests for binary installation and unified install flows |
| README.md | Updated documentation with installation instructions and binary location priority |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Improved install experience
Add --install top-level flag to perform all install behaviors.
Ensure binary is installed into a sensible PATH location.