Skip to content

Conversation

@erichs
Copy link
Owner

@erichs erichs commented Jan 3, 2026

Improved install experience

Add --install top-level flag to perform all install behaviors.
Ensure binary is installed into a sensible PATH location.

erichs added 2 commits January 2, 2026 16:43
Add --install top-level flag to perform all install behaviors.
Ensure binary is installed into a sensible PATH location.
Copilot AI review requested due to automatic review settings January 3, 2026 04:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 39.88658% with 318 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.42%. Comparing base (c5ae54a) to head (4166636).

Files with missing lines Patch % Lines
src/install/install.go 8.09% 158 Missing and 1 partial ⚠️
src/install/binary.go 60.55% 63 Missing and 36 partials ⚠️
src/install/filesystem.go 39.78% 49 Missing and 7 partials ⚠️
src/install/templates.go 80.00% 2 Missing ⚠️
src/main.go 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   86.80%   81.42%   -5.38%     
==========================================
  Files          61       62       +1     
  Lines        4144     4656     +512     
==========================================
+ Hits         3597     3791     +194     
- Misses        399      674     +275     
- Partials      148      191      +43     
Flag Coverage Δ
unittests 81.42% <39.88%> (-5.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a unified --install flag that streamlines the installation process by installing the dashlights binary to an appropriate PATH location, configuring the shell prompt, and automatically detecting and setting up AI agent hooks for Claude Code and Cursor in a single command.

Key changes:

  • Added --install flag for complete installation (binary + prompt + detected AI agents)
  • Implemented smart binary installation logic that respects existing locations, skips non-preferred directories, and falls back to ~/.local/bin with automatic PATH configuration
  • Automatic detection and installation of AI agent hooks when .claude or .cursor directories are present

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/main.go Added --install flag and integrated with install mode
src/install/templates.go Added PATH export templates for bash, zsh, and fish shells
src/install/install.go Implemented unified install orchestration with component detection and installation
src/install/filesystem.go Extended filesystem interface with binary-related operations (copy, chmod, symlink detection, PATH parsing)
src/install/binary.go New binary installer with smart PATH directory selection and version comparison
src/install/binary_test.go Comprehensive test coverage for binary installation scenarios
scripts/dockerized-install-test.sh Added integration tests for binary installation and unified install flows
README.md Updated documentation with installation instructions and binary location priority

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@erichs erichs merged commit 2d5dc85 into main Jan 3, 2026
5 checks passed
@erichs erichs deleted the improved-install branch January 3, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants