Put template string in variable before putting in array. This will avoi...

[ndebellas]

...d the Maximum call stack size exceeded on mac.

Unfortunate that the spacing has changed. I only intended to change 2 lines. Intent here is to fix an issue with mac where if one of the templates is too big, we get a "Maximum call stack size exceeded".

[ndebellas]

Let me know if you want me to recommit without the unintended spacing changes... Thank you

[ericclemmons]

I'm not sure about this one, particularly since I haven't heard of the issue nor experienced it.

Any idea on why this was an issue?

[underscorebrody]

@ndebellas Is this still a concern? If so I'd suggest re-committing without the spacing so we can more easily grok the changes. I'd also note that I haven't seen anything like this, do you have a sample template that can be used to reproduce?

[ndebellas]

Thank you for reaching out. I'll see if I can recommit without spacing.
Also I'll send a template... I believe it's still a concern, but only for
large templates...

Nick
On Nov 25, 2015 6:46 PM, "eric brody" notifications@github.com wrote:

@ndebellas https://github.com/ndebellas Is this still a concern? If so
I'd suggest re-committing without the spacing so we can more easily grok
the changes. I'd also note that I haven't seen anything like this, do you
have a sample template that can be used to reproduce?

—
Reply to this email directly or view it on GitHub
#108 (comment)
.