Skip to content

Speeds up truncation on 4K bytesize ~40x faster, 2k bytesize ~12x faster, #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
endform wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Speeds up truncation on 4K bytesize ~40x faster, 2k bytesize ~12x faster, #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/syslog_protocol/packet.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,16 @@ def assemble
raise "Could not assemble packet without hostname, tag, facility, and severity"
end
data = "<#{pri}>#{generate_timestamp} #{@hostname} #{@tag}: #{@content}"
while data.bytesize > 1024
data = data[0..(data.length-2)]

if data.bytesize > 1024
shortened = data.unpack('c*')[0..1023].pack('c*')
re_encoded = shortened.force_encoding(data.encoding)
while !re_encoded.valid_encoding? && data.valid_encoding? # multi byte char truncation
re_encoded = re_encoded[0..(re_encoded.length - 2)]
end
data = re_encoded
end

data
end

Expand Down