DOPE-256: simplify CustomTokenOptions and update related query string handling #87
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val queryString = typeExpression.toFunctionQueryString( | ||
| SearchFunctionType.SEARCH.type, | ||
| SearchFunctionType.SEARCH.queryString, | ||
| field?.queryString, | ||
| bucket?.queryString, |
There was a problem hiding this comment.
SearchFunctionType no longer exposes a type or other string property, yet the resolver still calls SearchFunctionType.SEARCH.queryString when building the function call. Because the enum only defines the three constants, this reference will not compile and the module fails to build. Use the enum name (e.g. SearchFunctionType.SEARCH.name) or an explicit mapping when creating the query string.
Useful? React with 👍 / 👎.
| is CustomTokenOptions -> { | ||
| val map = listOfNotNull( | ||
| "name" to resolvable.name, | ||
| resolvable.case?.let { "case" to "\"${it.queryString}\"" }, | ||
| "specials" to resolvable.specials, |
There was a problem hiding this comment.
The new TokenCases enum is bare, but the Couchbase resolver still emits resolvable.case?.let { "case" to "\"${it.queryString}\"" }. Since TokenCases does not define queryString, this code will not compile. The case value should be derived from the enum’s name (e.g. it.name) or by adding the missing property.
Useful? React with 👍 / 👎.
No description provided.