Skip to content

Conversation

@jansigi
Copy link
Collaborator

@jansigi jansigi commented Oct 30, 2025

No description provided.

@jansigi jansigi requested a review from pgruntz October 30, 2025 12:31
@jansigi jansigi self-assigned this Oct 30, 2025
@jansigi
Copy link
Collaborator Author

jansigi commented Nov 18, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 161 to 165
typeExpression.predicate as (Iterator<ValidType>) -> TypeExpression<BooleanType>
val predicate = predicateFunc(Iterator(iteratorName)).toDopeQuery(manager)
CouchbaseDopeQuery(
queryString = "${typeExpression.satisfiesType} `$iteratorName` " +
queryString = "${typeExpression.satisfiesType.queryString} `$iteratorName` " +
"IN ${array.queryString} SATISFIES ${predicate.queryString} END",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Replace undefined satisfies type string accessor

TypeExpressionResolver now formats SatisfiesExpression with typeExpression.satisfiesType.queryString, but SatisfiesType exposes no queryString property or extension. This change fails to compile and prevents any query using ANY, EVERY, or the new ANY_AND_EVERY from being resolved at all. Either add a property mapping the enum values to their Couchbase keywords (e.g. “ANY AND EVERY”) or revert to using the enum name.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants