-
Notifications
You must be signed in to change notification settings - Fork 57
BDY Mod #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AMLattanzi
wants to merge
36
commits into
erf-model:development
Choose a base branch
from
AMLattanzi:BdyMod
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
BDY Mod #2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify BDY Nudging
This PR changes how the BDY nudging is completed. Overall, the Laplacian stencil is removed, all of the bdy points are used for nudging, and the w velocity is copied from outside the nudging regions through the nudging region and into the domain ghost cells.
Notes
Idealized tests cases show that nudging with a stratified fluid will yield changes in the density that have non-linear pressure gradient effects. These effects have significant impact on the
w velocityinside the bdy region. We now copy thewvelocity from outside the bdy region into the bdy region and the ghost cells. This allows us to retain the needed later pressure gradient to forceu & vbut do not end up with erroneouswfrom dp/dz that was causing issues.Simplified test
Laterally forcing

u & vfrom an IC of0to1at the next time stamp yields:50 steps at dt=4s
200 steps at dt=4s


