Skip to content

Conversation

@kbattersby
Copy link
Contributor

@kbattersby kbattersby commented Dec 24, 2022

Increment version after table support changes.

EREZ-678

@kbattersby kbattersby requested review from a team and AlbertRothman and removed request for a team December 24, 2022 02:01
Copy link

@AlbertRothman AlbertRothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this do anything functional or just indicate what version we are on? If it doesn't do anything functional, then I don't find the commit completely clear. I'd shorten the subject to "Increment version" and then include the details about table support in the message.

@kbattersby
Copy link
Contributor Author

This particular commit for this PR right here does nothing other than increment the version. But the reason I want to increment the version is so that the table support changes can be released.
#77 (comment)

@kbattersby kbattersby changed the title Increment version for table support Increment version Jan 3, 2023
@AlbertRothman
Copy link

Thanks for the PR changes; looking at the commit history, it doesn't look like we use bors on this repo. Thus we need to change the actual commit message and comment not just the title and first comment on github.

Before merging this, I also wonder if we want to clean up the commit history for the last PR that landed multiple commits at once. I think this should be fine since it's pre-release, but maybe it's safer to just keep the extra commits. Thoughts?

@kbattersby
Copy link
Contributor Author

Thanks for the PR changes; looking at the commit history, it doesn't look like we use bors on this repo. Thus we need to change the actual commit message and comment not just the title and first comment on github.

Before merging this, I also wonder if we want to clean up the commit history for the last PR that landed multiple commits at once. I think this should be fine since it's pre-release, but maybe it's safer to just keep the extra commits. Thoughts?

Changed the name of the commit message. However since the previous commits have landed on master, I think it's better to just leave them as they are, but going forward to keep the commits clean.

@kbattersby kbattersby merged commit 5785b3c into erezlife:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants