specs(thread_safe_queue): producer registration and unregistration with concurrency#2
Merged
liamjdavis merged 2 commits intomainfrom Feb 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly expands and clarifies the documentation and verification approach for the Erdos Graph engine, focusing on formal verification practices with Verus. It adds a detailed explanation of the differences between formal verification and testing, introduces a style guide and naming conventions, outlines which Verus features are usable given the external code constraints, and provides many new and improved property-based proofs for the
ThreadSafeQueueAPI.The most important changes are:
Documentation and Guidelines:
CONTRIBUTING.mdto clearly distinguish between formal verification and testing, including purpose, structure, and writing approach, with illustrative examples.Verification Patterns and Examples:
CONTRIBUTING.mdof properties that can be verified (sequential behavior, functional correctness, limited concurrency properties) and those that cannot (true concurrency, deadlock freedom, liveness), with concrete proof sketches forThreadSafeQueue.Property-Based Proofs and Specs:
verified/src/thread_safe_queue_specs.rs, introduced uninterpreted spec functions and exec wrappers for keyThreadSafeQueueoperations (active_producer_count,producers_finished,queue_size), and added external type specifications for opaque types.Code and Comment Style Improvements:
check_*,verify_*).These changes make the verification process more robust, maintainable, and accessible for contributors.