Add more summary tests #1107
Add more summary tests #1107
Conversation
eivindjahren
force-pushed
the
use_resfo_utilities_for_summary
branch
from
30fc832 to
22f315f
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive test coverage for the Summary/rd_sum functionality in preparation for future refactoring. The changes introduce approximately 1000 lines of new tests covering various aspects of summary file handling.
Changes:
- Adds a
create_summaryhelper function to simplify test data generation - Implements 50+ new test functions covering Summary class methods, properties, and static methods
- Adds tests for reading, writing, interpolation, time handling, pandas integration, and CSV export
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| num_keywords=1 + len(summary_keys), | ||
| restart=" ", | ||
| keywords=["TIME "] + list(summary_keys), | ||
| well_names=[":+:+:+:+"] + [":+:+:+:+"] * len(summary_keys), |
There was a problem hiding this comment.
Could you briefly explain what these well names mean?
There was a problem hiding this comment.
This is called "DUMMY_WELL" in other parts of the code.
eivindjahren
force-pushed
the
use_resfo_utilities_for_summary
branch
2 times, most recently
from
f55f597 to
22ccbd7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated 13 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eivindjahren
force-pushed
the
use_resfo_utilities_for_summary
branch
2 times, most recently
from
458f11d to
6ec3447
Compare
eivindjahren
force-pushed
the
use_resfo_utilities_for_summary
branch
from
6ec3447 to
7246f99
Compare
We would like to be able to refactor rd_sum in the future. A first good step in that direction is adding more tests.