Skip to content

Add missing basemodel#1075

Merged
andchiind merged 1 commit intoequinor:mainfrom
andchiind:add-missing-base-model
Jan 27, 2026
Merged

Add missing basemodel#1075
andchiind merged 1 commit intoequinor:mainfrom
andchiind:add-missing-base-model

Conversation

@andchiind
Copy link
Contributor

@andchiind andchiind commented Jan 27, 2026

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like logging, TODO, etc.
  • The PR has been tested locally
  • A test has been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that requires new issues
  • The changes do not introduce dead code as unused imports, functions etc.

@andchiind andchiind force-pushed the add-missing-base-model branch from 938e86f to 3257197 Compare January 27, 2026 09:01
@andchiind andchiind force-pushed the add-missing-base-model branch from 3257197 to 3868688 Compare January 27, 2026 09:05
nicholasdalhaug
nicholasdalhaug approved these changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@nicholasdalhaug nicholasdalhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an earlier mistake

@andchiind andchiind merged commit 3e9bf2d into equinor:main Jan 27, 2026
7 checks passed
@andchiind andchiind deleted the add-missing-base-model branch January 27, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicholasdalhaug nicholasdalhaug nicholasdalhaug approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andchiind @nicholasdalhaug