Make parameters table in Manage Experiments non-editable #12688
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the data presented to the user is identical with the data exported. It follows the same approach how other tables in ERT are made non-editable.
I was considering to add a test for this, but it seems that there are no such tests for the other tables. I also found some pitfalls w.r.t. tests:
NoEditTriggersproperty in the test does not actually reproduce the behavior of user when interacting with the GUI.ItemIsEditableflag from each model describing a table cell instead of removing edit triggers. In this case the test would have to be rewritten.pytest-qtpackage advises to avoid actions depending on the event loop.setTextis not covered by the event triggers which means thatsetTextsucceeds even if the cell itself is non-editable.Issue
Resolves #12574
Approach
The triggers to edit the
QTableWidgetare removed. It follows the same approach how other tables in ERT are made non-editable.This video should show that the clicking/double clicking on the grid cell does not enter the "Edit" mode of the cell. I don't know if there is a better way to show that the cell is not editable.
Screen.Recording.2026-01-20.at.15.05.40.mov
git rebase -i main --exec 'just rapid-tests')When applicable