-
Notifications
You must be signed in to change notification settings - Fork 123
Skip rft observations from csv if value -1 #12676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Skip rft observations from csv if value -1 #12676
Conversation
fa46661 to
ab3652c
Compare
A value of -1 and error of 0 is used by fmu.tools.rms create_rft_ertobs to indicate missing data. If encountered in an rft observations csv file it should be skipped and create a user warning.
ab3652c to
91b5825
Compare
|
I guess we will need this workaround for a while at least, but should we also change the creation of the csv file so that it does not include rows that are not correct? Thoughts @oyvindeide & @berland ? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12676 +/- ##
==========================================
- Coverage 90.68% 90.64% -0.04%
==========================================
Files 429 429
Lines 29808 29816 +8
==========================================
- Hits 27030 27028 -2
- Misses 2778 2788 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
| ConfigWarning.warn( | ||
| ( | ||
| f"Value=-1 and error=0 detected for well {row.WELL_NAME} " | ||
| f"at date {row.DATE} in {filename}. The row will be ignored" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"row" is an implementation detail. Should probably say something along: "The observation at that date will be ignored"
A value of -1 and error of 0 is used by fmu.tools.rms create_rft_ertobs to indicate missing data. If encountered in an rft observations csv file it should be skipped and create a user warning.
Issue
Resolves #12448
Approach
Added test to ensure rows with value -1 and error 0 are skipped with a warning
and added required functionality.
git rebase -i main --exec 'just rapid-tests')When applicable