Fix math domain error in histogramLogBins (Issue #12527) #12657
+45
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
reviewed
Jan 19, 2026
|
|
||
| return 10 ** np.linspace(minimum, maximum, log_bin_count) | ||
| minimum = log10(float(minimum)) | ||
| maximum = log10(float(maximum)) |
Contributor
There was a problem hiding this comment.
You still have to return something
Contributor
There was a problem hiding this comment.
@N9sha18 Can you verify that the tests still pass locally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a ValueError when plotting log-scale histograms with non-positive data. Added a check to clamp minimum values
Relates to #12527