Skip to content

Conversation

@jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Jan 9, 2026

Issue
Resolves #12601

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@jonathan-eq jonathan-eq self-assigned this Jan 9, 2026
@jonathan-eq jonathan-eq added the release-notes:unreleased-feature-changes PR with changes to a feature which is not yet released. Not for introduction of new features! label Jan 9, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.65%. Comparing base (f0d9de4) to head (04fcd90).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12614      +/-   ##
==========================================
- Coverage   90.68%   90.65%   -0.03%     
==========================================
  Files         429      429              
  Lines       29808    29799       -9     
==========================================
- Hits        27030    27015      -15     
- Misses       2778     2784       +6     
Flag Coverage Δ
cli-tests 37.55% <ø> (-0.01%) ⬇️
gui-tests 69.37% <ø> (+0.01%) ⬆️
performance-and-unit-tests 73.92% <ø> (-0.01%) ⬇️
test 38.07% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 9, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing jonathan-eq:fix-private-ip-address (04fcd90) with main (f0d9de4)

Summary

✅ 22 untouched benchmarks

@jonathan-eq jonathan-eq force-pushed the fix-private-ip-address branch from 8641063 to 2717e36 Compare January 12, 2026 13:22
@jonathan-eq jonathan-eq force-pushed the fix-private-ip-address branch from 2717e36 to 71e0ebd Compare January 12, 2026 13:38
Site configuration
~~~~~~~~~~~~~~~~~~~~~
Ert can be configured by plugins through
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword this by emphasizing that some global options can be additionally configured by this. I'll leave the exact formulation to you :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about Ert can have some global options set by plugins through the `ert.plugins.hook_specifications.site_config.site_configurations` hook.

@jonathan-eq jonathan-eq force-pushed the fix-private-ip-address branch from 71e0ebd to 68c4d43 Compare January 19, 2026 08:15
@jonathan-eq jonathan-eq requested a review from xjules January 19, 2026 13:44
@jonathan-eq jonathan-eq force-pushed the fix-private-ip-address branch from 68c4d43 to e13252e Compare January 19, 2026 14:00
Site configuration
~~~~~~~~~~~~~~~~~~~~~
Ert can have some global options set by plugins through
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, if this convey the info properly. The point is that these are defaults. But prioritize can be set only via site-config.

@jonathan-eq jonathan-eq force-pushed the fix-private-ip-address branch from e13252e to d74539b Compare January 20, 2026 06:57
@jonathan-eq jonathan-eq force-pushed the fix-private-ip-address branch from d74539b to 04fcd90 Compare January 20, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:unreleased-feature-changes PR with changes to a feature which is not yet released. Not for introduction of new features!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PRIORITIZE_PRIVATE_IP_ADDRESS should be only set via site-config

3 participants