-
Notifications
You must be signed in to change notification settings - Fork 123
Have PRIORITIZE_PRIVATE_IP_ADDRESS available only via site config #12614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12614 +/- ##
==========================================
- Coverage 90.68% 90.65% -0.03%
==========================================
Files 429 429
Lines 29808 29799 -9
==========================================
- Hits 27030 27015 -15
- Misses 2778 2784 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
8641063 to
2717e36
Compare
2717e36 to
71e0ebd
Compare
| Site configuration | ||
| ~~~~~~~~~~~~~~~~~~~~~ | ||
| Ert can be configured by plugins through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd reword this by emphasizing that some global options can be additionally configured by this. I'll leave the exact formulation to you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about Ert can have some global options set by plugins through the `ert.plugins.hook_specifications.site_config.site_configurations` hook.
71e0ebd to
68c4d43
Compare
68c4d43 to
e13252e
Compare
| Site configuration | ||
| ~~~~~~~~~~~~~~~~~~~~~ | ||
| Ert can have some global options set by plugins through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, if this convey the info properly. The point is that these are defaults. But prioritize can be set only via site-config.
e13252e to
d74539b
Compare
d74539b to
04fcd90
Compare
Issue
Resolves #12601
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable