Skip to content

Conversation

@yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Jan 8, 2026

Towards #11513. Note: Seems refcase/time map really must be removed for this to work cleanly

@yngve-sk yngve-sk changed the title Make observation declarations into discriminated union Move observations parsing to runmodel Jan 8, 2026
@yngve-sk yngve-sk added this to SCOUT Jan 8, 2026
@yngve-sk yngve-sk moved this to In Progress in SCOUT Jan 8, 2026
@yngve-sk yngve-sk self-assigned this Jan 8, 2026
@yngve-sk yngve-sk force-pushed the 26.01.move-observations-handling branch from 328b7bf to 22ccaa0 Compare January 8, 2026 11:43
@yngve-sk yngve-sk force-pushed the 26.01.move-observations-handling branch from 22ccaa0 to d4c7217 Compare January 8, 2026 11:45
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.55%. Comparing base (a29328d) to head (5865504).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12597      +/-   ##
==========================================
- Coverage   90.55%   90.55%   -0.01%     
==========================================
  Files         435      435              
  Lines       29940    29996      +56     
==========================================
+ Hits        27112    27162      +50     
- Misses       2828     2834       +6     
Flag Coverage Δ
cli-tests 37.42% <90.24%> (+0.07%) ⬆️
gui-tests 68.62% <97.56%> (-0.05%) ⬇️
performance-and-unit-tests 73.93% <100.00%> (+0.01%) ⬆️
test 38.11% <68.29%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk marked this pull request as ready for review January 8, 2026 11:57
@yngve-sk yngve-sk force-pushed the 26.01.move-observations-handling branch 2 times, most recently from eb3d13e to 9f95c97 Compare January 8, 2026 12:53
@yngve-sk yngve-sk force-pushed the 26.01.move-observations-handling branch from 9f95c97 to 5865504 Compare January 8, 2026 13:13
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 8, 2026

Merging this PR will not alter performance

Summary

✅ 22 untouched benchmarks


Comparing yngve-sk:26.01.move-observations-handling (5865504) with main (ef47dad)

Open in CodSpeed

@yngve-sk yngve-sk marked this pull request as draft January 20, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants