feat: BETA loadbalancer service support#362
Conversation
tylerauerbeck
left a comment
There was a problem hiding this comment.
Just a few comments, but overall this looks like a great start!
| } | ||
|
|
||
| func (m TokenExchanger) Token() (*oauth2.Token, error) { | ||
| tokenExchangeURL := "https://iam.metalctrl.io/api-keys/exchange" |
There was a problem hiding this comment.
Don't know that it would add much here, but if we had a spec for iam.metalcrtl.io we could use a generated client.
|
One thing to consider here: if LBaaS has its own generated client that sits next to the metal client in |
|
Merged in latest updates and tested create/get/delete commands to verify they work. |
cprivitere
left a comment
There was a problem hiding this comment.
One thing to consider here: if LBaaS has its own generated client that sits next to the metal client in
equinix-sdk-go, with its own spec and its own API endpoint, that may indicate that LBaaS CLI commands should go alongside Metal CLI commands in a broader-scoped Equinix CLI (eqx?eqix?the-equinix-cli?) rather than directly in here.
I'm all for dropping metal-cli and making eq-cli or whatever.
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
…quinix-metal emlb branch) Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Part of #411
(Used CPEM's LBaaS Go project as the base. Lots of cleanup ahead. )
This PR introduces the minimal subcommand support to start working with LoadBalancers. This PR does not include ports and pools, which can be added later.
TODO: