Skip to content

ci: updated #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tutkat merged 2 commits into from
Jan 26, 2026
Merged

ci: updated #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c42b508
updated
tutkat Jan 26, 2026
66e88af
fix flow
tutkat Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/fabricv4_test_runner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: Test Equinix SDK Java Runner

on:
pull_request:
branches:
- main
workflow_dispatch:

jobs:
Expand Down Expand Up @@ -72,8 +75,8 @@ jobs:
run: |
mvn test \
-Dtest=${{ matrix.testConfig.class }} \
-DenvUrl="${{ secrets.TEST_HOST_URL }}" \
-DuatUsers="${{ secrets.TEST_DATA_UAT_USERS }}" \
-DenvUrl='${{ secrets.TEST_HOST_URL }}' \
-DuatUsers='${{ secrets.TEST_DATA_UAT_USERS }}' \
-Djava.version=${{ matrix.testConfig.jdk }} \
-Dmaven.compiler.source=${{ matrix.testConfig.jdk }} \
-Dmaven.compiler.target=${{ matrix.testConfig.jdk }}
Expand Down Expand Up @@ -187,3 +190,4 @@ jobs:
*Test Runs:* ${{ needs.test.outputs.tests_run }}
*Results:* ${{ steps.set-output-passed.outputs.total_passed }} Passed, ${{ steps.set-output-failed.outputs.total_failed }} Failed
*Triggered by:* <@${{ github.actor }}>
*Responsibility:* <@U04AM0XBJMA>
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded Slack user ID makes the workflow less maintainable. Consider using a workflow input variable or repository secret for the responsible person's Slack ID. This would make it easier to update the responsible person without modifying the workflow file directly.

Suggested change
*Responsibility:* <@U04AM0XBJMA>
*Responsibility:* <@${{ secrets.SLACK_RESPONSIBLE_USER_ID }}>

Copilot uses AI. Check for mistakes.
Copy link
Member

@displague displague Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tutkat I added this secret to the repo settings, so we can take on this change in a subsequent PR.

2 changes: 1 addition & 1 deletion ...napi-fabric-tests/src/test/java/com/equinix/openapi/fabric/tests/CloudRoutersApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
*/
public class CloudRoutersApiTest {

private static final UsersItem.UserName userName = UsersItem.UserName.PANTHERS_FNV;
private static final UsersItem.UserName userName = UsersItem.UserName.PANTHERS_FCR;

public static void removeCloudRouters(UsersItem.UserName userName) {
users.get(userName).getUserResources().getCloudRoutersUuid().forEach(uuid -> {
Expand Down
2 changes: 1 addition & 1 deletion ...-openapi-fabric-tests/src/test/java/com/equinix/openapi/fabric/tests/NetworksApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* API tests for NetworksApi
*/
public class NetworksApiTest {
private static final UsersItem.UserName userName = UsersItem.UserName.PANTHERS_FNV;
private static final UsersItem.UserName userName = UsersItem.UserName.PANTHERS_FCR;

public static void removeNetworks(UsersItem.UserName userName) {
users.get(userName).getUserResources().getNetworksUuid().forEach(NetworksApiTest::deleteNetwork);
Expand Down
2 changes: 1 addition & 1 deletion ...-fabric-tests/src/test/java/com/equinix/openapi/fabric/tests/RoutingProtocolsApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ private static void waitForBGPTypeIsProvisioned(UUID routingProtocolUuid, String
break;
}
try {
Thread.sleep(3000);
Thread.sleep(10000);
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Thread.sleep() for polling provisioning status is inefficient and can lead to unnecessarily long test execution times. Consider implementing an exponential backoff strategy or a more sophisticated polling mechanism with a configurable timeout and shorter intervals. This would allow the test to proceed as soon as the resource is provisioned rather than always waiting the full 10 seconds.

Copilot uses AI. Check for mistakes.
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
Expand Down
Loading