chore: fix debug flag for commands generated from SDK#38
Merged
Conversation
ctreatma
force-pushed
the
fix-debug-flag
branch
2 times, most recently
from
41d4fb0 to
da8b7d5
Compare
ctreatma
force-pushed
the
fix-debug-flag
branch
from
da8b7d5 to
949d8e5
Compare
ctreatma
force-pushed
the
fix-debug-flag
branch
from
949d8e5 to
8a68cd3
Compare
|
This PR is included in version 0.3.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--debugflag is not wired up in commands that are generated withmake onboard. While investigating that issue, I also uncovered that the code to create an authenticated client at command execution time was not in use.This fills in the missing pieces to define the
--debugflag and create an authenticated, potentially-debug-enabled HTTP client at runtime.As part of this the API clients defined in
internal/api/api.gowere refactored to use a transport for injecting common headers so that the Metal client can be reused by themetalv1subcommand.This is dependent on #34 and is in draft until that PR makes it through review.