Remove jQuery from docs; addresses #139 and #238#242
Open
eyqs wants to merge 1 commit intoepochjs:gh-pagesfrom
eyqs:gh-pages
Open
Remove jQuery from docs; addresses #139 and #238#242eyqs wants to merge 1 commit intoepochjs:gh-pagesfrom eyqs:gh-pages
eyqs wants to merge 1 commit intoepochjs:gh-pagesfrom
eyqs:gh-pages
Conversation
This addresses issues #139 and #238, which complained that the examples in the documentation require jQuery to work. The jQuery dependence has been removed by pull request #84. According to issue #91, there should be no jQuery requirement in the documentation either, and indeed the documentation does not have `<script src="js/jquery.min.js"></script>` anywhere. Nevertheless, all the examples in the documentation still use jQuery. As it is now 2018, nobody uses jQuery anymore, and #145 shows how to use Epoch without jQuery, this commit and pull request removes jQuery from all the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issues #139 and #238, which complained that
the examples in the documentation require jQuery to work.
The jQuery dependence has been removed by pull request #84.
According to issue #91, there should be no jQuery requirement
in the documentation either, and indeed the documentation does
not have
<script src="js/jquery.min.js"></script>anywhere.Nevertheless, all the examples in the documentation still
use jQuery. As it is now 2018, nobody uses jQuery anymore,
and #145 shows how to use Epoch without jQuery, this commit
and pull request removes jQuery from all the documentation.