Merged
Conversation
- Resolves open-ended gem versioning warnings by setting explicit version minimums for Faraday and its middleware dependencies. - Ensures compatibility with Faraday v2, which requires individual middleware to be specified.
- Resolves open-ended gem versioning warnings. - Sets explicit minimum versions for Faraday and its middleware dependencies, mitigating potential compatibility issues and ensuring consistent behaviour.
- Modifies Bundler to specify the default group and Rails environment. - Suppresses SASS deprecation warnings from dependencies to maintain a clean console output. This ensures developers are not distracted by warnings that do not require immediate action. - Silences `@import` deprecation warnings during the migration to `@use` and `@forward`, providing a smoother transition. - Adds the `services` directory to the autoload paths, enabling easy access to service classes throughout the application. - Monkey-patches Rails to output start-up log messages in JSON format for better integration with combined logging services. This allows for standardised and parsable log entries. Related to #182
- Updates the project to use Dart Sass instead of Ruby Sass. - This change modernises the Sass compilation process and improves compatibility with newer front-end tools. - Removes the deprecated `sass-rails` gem and introduces `dartsass-sprockets`. - Updates `lr_common_styles` to Bootstrap 5, aligning with current standards. - Includes necessary updates for related gems like `autoprefixer-rails`. - Removes redundant gems to streamline the project's dependencies. - Adds `htmlbeautifier` gem for development, which helps maintain consistent code style. - Updates `faraday` gem version. - Moves `stackprof` gem declaration before `sentry-rails` - Groups `sdoc` gem declaration inside `:doc` Relates to #182
- Configures Autoprefixer to generate source maps for easier debugging of CSS. - Registers a custom processor for Autoprefixer that includes source map generation. - Updates the asset configuration to use the custom Autoprefixer processor. Relates to #182
- Enables SASS source maps in development for easier debugging, allowing developers to trace styles back to their origin in the source code. - Sets SASS output style to compressed in production for smaller file sizes, improving website performance.
- Updates the Makefile to streamline development processes and improve maintainability.
- Updates the .gitignore file to exclude local TODO files and wget logs.
- Configures the asset pipeline to use the correct dependencies and stylesheets. - Replaces the old application.scss with a new one, including necessary imports like govuk-template, bootstrap, font-awesome, and leaflet. - Includes popper.js in the application javascript file for enhanced Bootstrap functionality.
- Updates Sentry initialisation for clarity and flexibility. - Allows disabling Sentry in specific environments by unsetting the API key, providing better control over error reporting. - Updates the Sentry environment configuration to use the instance configuration value to align with deployment practices. - Replaces `config.logger.level` with `config.sdk_logger.level` to correctly configure the SDK logger level and filter error reporting effectively. - Documents the purpose of sample rates and environment variables. - Standardises variable naming.
- Updates the report detail toggle text for clarity and by making the toggle more descriptive.
- Removes unnecessary clearfix divs from view templates. - Ensures consistent styling across different screen sizes by adjusting offsets.
- Adds padding to the help link for improved visual spacing. - This change enhances the user interface by providing a more visually appealing layout.
- Removes the erroneous class promoting consistency across the application.
- Modifies CSS classes to follow new Bootstrap conventions - Updates font size and spacing for enhanced readability. Refs: #182
- introduces root variables for consistent styling - improves form control layout and appearance - enhances button styles for better user experience - uses variables for font sizes and colours.
- bumps the minor version to reflect feature enhancements - resets the patch version to zero for a new release cycle
- replaces `sass-rails` with `dartsass-sprockets` - uses Dart Sass for improved compatibility - enables Sass source maps for front-end debugging - adds Autoprefixer for CSS debugging - configures Sass compression in production
## Summary Replaced deprecated `sass-rails` gem with Dart Sass and updated styling for Bootstrap 5 compatibility. Specific to ticket #182 ## Changes - Replaced `sass-rails` with `dartsass-sprockets` for Dart Sass compatibility - Updated `lr_common_styles` gem (includes Bootstrap 5) - Enabled Sass source maps for front-end debugging - Added Autoprefixer with source map generation - Modernised stylesheets with Bootstrap conventions - Improved Sentry initialisation with better environment control - Streamlined Makefile for improved development workflow ## Breaking Changes None ## Checklist ### Testing - [x] Manual testing completed - [x] No regressions introduced ### Build & Assets - [x] Assets compile successfully - [x] Linting passes (rubocop, eslint) - [x] Docker image builds successfully ### Process & Quality - [x] Changelog updated
- Updates test dependencies to align with current testing approaches. - Removes the `minitest-rails-capybara` and `minitest-vcr` gems, as their functionalities are now better handled by other tools. - Adds `selenium-webdriver` for enhanced browser testing capabilities. - Specifies `require: false` for `minitest-rails` and `minitest-spec-rails`, allowing more explicit control over when these libraries are loaded.
- introduces capybara feature tests to replace a deprecated gem - provides feature/scenario dsl for capybara feature tests - extends minitest::expectation with capybara matchers
- Ensures county selections are validated correctly. - Updates the validation logic to handle potential mismatches. - Implements improved area selection summaries. - Normalises the returned value.
- ensures consistent API endpoint across environments. - avoids potential connectivity issues with the service. Related to #155
- Resolves open-ended gem versioning warnings by setting explicit minimum versions for Faraday and its middleware dependencies.
- Updates changelog to reflect changes introduced in issue #155 in prep for rc
## Summary Investigated failing tests and resolved underlying issues with county selection validation whilst modernising the test infrastructure with Capybara support. Specific to ticket #155 ## Changes - Introduced Capybara feature test support with scenario DSL for improved integration testing - Corrected county selection validation to handle mismatched values - Refactored test dependencies for improved maintainability ## Checklist ### Testing - [x] Unit tests added/updated - [x] Manual testing completed - [x] No regressions introduced ### Build & Assets - [x] Linting passes (rubocop, eslint) - [x] Docker image builds successfully ### Process & Quality - [x] Changelog updated
Relates to #155, #182, #185 ## What's Changed ### Added - Introduced Capybara feature test support with scenario DSL [#155](#155) - Enabled Sass source maps for front-end debugging in development - Added Autoprefixer with source map generation for CSS debugging - Added root CSS variables for consistent styling ### Changed - Corrected county selection validation to handle mismatched values [#155](#155) - Replaced `sass-rails` with `dartsass-sprockets` for Dart Sass compatibility [#182](#182) - Updated `lr_common_styles` gem (includes Bootstrap 5) - Modernised stylesheets with Bootstrap conventions - Improved form control layout and button styles - Enhanced report styling with improved font sizes and spacing - Updated report detail toggle text for clarity - Simplified layout templates by removing unnecessary elements - Improved Sentry initialisation with better environment control - Streamlined Makefile for improved development workflow - Configured Sass compression in production for smaller bundles - Resolved open-ended gem versioning warnings by setting explicit minimum versions ### Fixed - Refactored test dependencies for improved maintainability [#155](#155) ### Removed - Removed deprecated `sass-rails` gem and redundant dependencies **Full Changelog**: v2.2.2...v2.3.0
joescottdave
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy Target: Prod
Tip
This is a release PR. Code has been reviewed and deployed to development.
Approval required only for the version and changes listed below.
Relates to #155, #182, #186
What's Changed
Added
#155
Changed
#155
sass-railswithdartsass-sprocketsfor Dart Sass compatibility#182
lr_common_stylesgem (includes Bootstrap 5)Fixed
#155
Removed
sass-railsgem and redundant dependenciesFull Changelog: v2.2.2...v2.3.0