Merged
Conversation
- Refactors plugin declaration for improved readability - Prepares config for handling multiple plugins
- Deletes the TargetRubyVersion setting to revert to a global default - [https://docs.rubocop.org/rubocop/configuration.html#setting-the-target-ruby-version]
- Naming/BlockForwarding - Style/ArgumentsForwarding
- Change directive from Naming/PredicateName to Naming/PredicatePrefix - Improve method naming clarity by complying with rubocop standards
- Modify layout_submit_button to accept a workflow parameter - Update button elements to include data-action and aria-label attributes - Conditionally disable back button when workflow parameters are blank - Incorporate changes into existing views using layout_submit_button
- Renames a method to use a question mark for consistency - Ensures validation logic is correctly invoked
- Replace middleware with specific gems for encoding, follow redirects, and retry functionality - Ensure compatibility with the Faraday ecosystem
- Handle additional timeout exceptions in API requests - Improve JSON parsing by ensuring input is a string - Add retry options for HTTP connections - Log API connection failures and parse errors only in production - Provide detailed error messages with Sentry integration
- Include new logging module for unified log handling - Add Sentry integration to capture errors and messages - Improve logging clarity for different error scenarios
- Change auto-correct flag from -A to -a - Improve default behaviour for code corrections
- Upgrade Rails to version 8.0.2 - Update various gem dependencies to their latest versions - Replace faraday_middleware with specific Faraday dependencies - Ensure gem compatibility with platforms like aarch64 and x86_64 - Maintain security and performance improvements by using the recent gem versions
- Remove predicate naming convention for validation methods - Disable Rubocop predicate naming rule for updated methods - Enhance readability by aligning method names with their purpose
- Make radio buttons required for improved form validation - Allow conditional enabling of submit buttons - Add specific flash messages for empty selections - Enable title case formatting for summaries - Improve validation logic for form fields
- Style buttons when disabled with consistent colours - Prevent focus ring and box-shadow on disabled buttons - Enhance accessibility by adjusting cursor on hover
- Change text-muted paragraph class to small for consistent styling with other elements - Remove unnecessary class from the second paragraph to simplify the markup
- Recreates the execution script for improved bundler version handling - Introduces version checking using both environment and CLI args - Improves gemfile and lockfile path determination - Adds bundler activation with error handling for compatibility
- Introduces a new method for title capitalisation based on grammar specific rules
- Introduce helper to standardise title casing - Replace titleize with custom titleise method - Improve validation and user feedback consistency
- Update gem dependencies for compatibility and performance - Refactor string handling with a new helper method - Ensure consistent styling for disabled buttons - Update methods for clearer naming and logic flow - Improve bundler command execution and error logging
- Increment minor version to reflect new features and functionality - Reset patch version since it's a minor update
- Update Alpine version for better compatibility - Modify tag format for consistency - Enhance bundle and rails command usage - Clean and optimise asset management tasks - Add relative URL root to build arguments - Introduce force clean and name targets - Improve log and temporary file cleanup
- Simplifies container management by using 'make' commands - Adds dynamic countdown before running docker commands - Ensures cleanup via direct container stop command
- Add patterns to ignore Ruby and Rails specific files - Include config files related to development tools - Ensure coverage and temporary files are ignored
This pull request introduces a variety of changes across multiple areas, including updates to dependencies, improvements to pre-commit and pre-push hooks, enhancements to the Makefile, styling updates, and refactoring of helper methods and models. Below is a summary of the most important changes organized by theme. ### Dependency Updates * Updated `Gemfile` to replace `faraday_middleware` with `faraday-encoding`, `faraday-follow_redirects`, and `faraday-retry` for better modularity and functionality. * Updated `.rubocop.yml` to fix plugin syntax and removed the `TargetRubyVersion` setting. ### Build and Deployment Enhancements * Modified `.githooks/pre-commit` to use the `-a` option with Rubocop for autocorrect instead of `-A`. * Improved `.githooks/pre-push` by simplifying Docker container handling, replacing `sleep` with a countdown, and using `make` commands for consistency. * Enhanced the `Makefile` with new variables (`RAILS_RELATIVE_URL_ROOT`), streamlined asset handling, and added a `forceclean` target for thorough cleanup. [[1]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L1-R4) [[2]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L13-R66) [[3]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R76-R101) ### Styling and UI Improvements * Added consistent styling for disabled buttons in `app/assets/stylesheets/standard-reports.scss`. * Updated helper methods to ensure buttons have clearer logic and accessibility attributes, such as `aria-label` and `required`. [[1]](diffhunk://#diff-1af5389057dc20ee7500508da8b9c12c8b166812d6d5b80ef1ae972257fb6badL16-R16) [[2]](diffhunk://#diff-1af5389057dc20ee7500508da8b9c12c8b166812d6d5b80ef1ae972257fb6badL93-R113) ### Helper and Model Refactoring * Introduced a `titleise` helper method in `ApplicationHelper` for consistent capitalization of titles based on grammar rules. * Refactored validation methods in models to improve error handling and messaging for invalid selections. [[1]](diffhunk://#diff-34718d6a350d71fe3a36bd84bdf75f79cc4f343a1bfcc8b43cc6df15dfb08fb8L39-R46) [[2]](diffhunk://#diff-9b34491f7e4bf1e50533a3f297b45a8cc95d0dc880352a4316e3cee472badf06L24-R45) [[3]](diffhunk://#diff-fdcf532ac11410610808986d24ef74525f1f4a4e8ee0a5be76f2d172d94d01cdL51-R58) ### Logging and Error Handling * Enhanced error logging in `ReportManager` to use Sentry for capturing messages and exceptions in production environments. * Updated `ReportManagerApi` to handle `Faraday::TimeoutError` in addition to `Faraday::ConnectionFailed`. These changes collectively improve the project's maintainability, user experience, and overall reliability.
- introduce guide for automation hook workflow - document how to install, skip, and configure hooks - add reference links and usage clarifications
- enhance status logs with branch context - update skip logic messaging to align with docs
- disable automatic test running (commented out) - keep structure and future test code for reference
- reorder and deduplicate core dependencies - clarify comments for local and remote resources - rework development tool groups and update toolchain - add language tooling and developer tools
- add and update language server, rubocop, runner gems - pin dependencies for development productivity - bump rails and key gems with compatibility fixes - sync lockfile to match new dependency manifest
- expand comments to document word-case rules - clarify grammar and intent of title casing
- add missing environment and log level variables - extend sentry configuration with new keys - improve local setup consistency and error reporting
- introduce new heading for version 2.2.0
- Upgrades dependencies, including Rails, to address security issues - Improved environment configs for logging and error tracking - Updates tooling and lock files for smoother development - Clarified and reorganise comments and messaging across scripts - Adds documentation for automation and workflow setup - Commented out non-essential automation steps for clarity
- Groups development dependencies for better organisation - Adds and clarifies comments for easier onboarding - Updates bundler version for improved compatibility
- upgrade to latest release of shared style assets - update dependency bounds for style framework
- bump core library and protocol package versions - ensure compatibility with latest releases
- Increments patch number for the next release - Prepares for small updates and bug fixes
- updates LR Common Styles gem dependency for security updates - document ongoing improvements to configs and tooling
This pull request includes a minor version bump and updates the changelog to reflect recent dependency upgrades and security improvements. Version and changelog updates: * Incremented the patch version to `2.2.1` in `app/lib/version.rb` to prepare for a new release. * Added a new entry for version `2.2.1` in `CHANGELOG.md`, highlighting the update of the LR Common Styles gem and ongoing dependency/security improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the development workflow, environment configuration, dependency management, and UI consistency. The most important changes include enhanced automation and documentation for git hooks, updates to environment variables for better logging and error tracking, significant updates to the
Gemfilefor dependency clarity and security, improvements to the Makefile for streamlined commands and Docker support, and UI refinements for disabled buttons and form accessibility.Development Workflow and Automation:
.githooks/README.md, detailing automation, skipping options, and setup instructions..githooks/post-commitand.githooks/pre-committo clarify when hooks are skipped and to refine Rubocop invocation. [1] [2] [3]Environment Configuration and Logging:
.env.developmentto include new variables forRAILS_ENV,LOG_LEVEL, and Sentry configuration, improving error tracking and logging granularity.Dependency and Gem Management:
Gemfileto clarify development dependencies, update Faraday-related gems for improved HTTP handling, and provide more explicit comments for local vs. remote gem usage. Also reorganized dev tools and updated meta_request to a specific GitHub ref. [1] [2] [3] [4].rubocop.ymlto fix plugin loading and exclude specific model files from linting.Build and Docker Workflow:
Makefilewith support for new Alpine version, improved asset and cache cleaning, added forceclean and name targets, streamlined realclean, and updated Docker build arguments for better environment consistency. [1] [2] [3] [4] [5].githooks/pre-pushto usemake namefor container identification and refined Docker run/stop logic for reliability.UI and Accessibility Improvements:
standard-reports.scss, ensuring proper color and focus behavior.report_design_helper.rb. [1] [2] [3]Other notable updates include a new string titleization helper, minor version bump, improved validation error messaging, and changelog updates for transparency.