Conversation
kal
requested changes
Dec 9, 2025
Contributor
kal
left a comment
kal
left a comment
There was a problem hiding this comment.
Couple of issues to address.
pom.xml
Outdated
| <groupId>com.epimorphics</groupId> | ||
| <artifactId>appbase</artifactId> | ||
| <version>3.1.14</version> | ||
| <version>4.0.0-SNAPSHOT</version> |
Member
There was a problem hiding this comment.
Why?
This is normally released through mvn release so the release will be 4.0.0 but at this stage the pom should say 4.0.0-SNAPSHOT surely. Think I'm missing something.
test/mapping/sampling-points.ttl
Outdated
| @@ -1,8 +1,25 @@ | |||
| PREFIX api: <http://purl.org/linked-data/api/vocab#> | |||
Contributor
There was a problem hiding this comment.
Why are these prefixes added? There's nothing in the test file that I can see that references them.
Contributor
Author
There was a problem hiding this comment.
Removed.
kal
approved these changes
Dec 9, 2025
der
approved these changes
Dec 9, 2025
Member
der
left a comment
der
left a comment
There was a problem hiding this comment.
All looks good, thanks. Impressively quick bit of work.
My concern over the SNAPSHOT versioning isn't a blocker, do whatever you had planned to release it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies with major impact.