Conversation
Jena uses -1 on timeouts to mean "no timeout" and the defaut settings in RemoveSparqlSource follow that convention. This was resulting in illegal Duration parameters. Fix that, and added an EmbeddedFuseki option so can no leave the test enabled.
Fix RemoteSparqlSource
Jena 5.5 -> 5.6 Tomcat 11.0.10 -> 11.0.12 Both updates are to address reported vulnerabilities in the older versions
Bump Jena and Tomcat versions
der
approved these changes
Dec 5, 2025
Member
der
left a comment
der
left a comment
There was a problem hiding this comment.
Looks great thanks. Was worried about containsModel but can't find a use so not worth addressing.
README.md
Outdated
| * Maven artifacts for Appbase version 4.0.0 and onwards are published to the Epimorphics public S3 Maven repository. | ||
| * The `DatasetAccessor` interface from Jena 3 is replaced by `com.epimorphics.appbase.data.DatasetAccessor`: | ||
| * It is directly implemented by `RDFConnectionDatasetAccessor` and indirectly by various wrapper classes which are unchanged from the previous version. | ||
| * It has removed the `containsModel` method since no Jena 5 equivalent exists. Instead, use `getModel` to obtain the model, then `isEmpty` on the model. |
Member
There was a problem hiding this comment.
Don't think that's a viable workaround for a large model but can find any uses of it downstream so not a show stopper. Suggest removing the second sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java 21
Tomcat 9 -> 11
Jena 3.9 -> 5.6
Lib 3.1 -> 4.0
Jersey 2.25 -> 3.1