Merged
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
…e from token request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip
resourcefrom OAuth request params beforecompleteAuthorizationto avoid local audience mismatch failures on/db-api.Closes #9
Note
Medium Risk
Touches OAuth authorization/token request handling; while small, it changes how audiences may be derived and relies on request cloning semantics that could affect compatibility with some clients.
Overview
Prevents audience-bound tokens from being created from MCP clients’
resourceparameter by strippingresourcebefore callingcompleteAuthorizationinapp/routes/oauth/authorize.tsx.Fixes token endpoint compatibility by reading the
/oauth/tokenform body viarequest.clone()before removingresource, avoiding consuming the original request body inworkers/app.ts.Written by Cursor Bugbot for commit 5557ea9. This will update automatically on new commits. Configure here.