Open
Conversation
Collaborator
Author
|
@tboegi do you have a test crate where we can test this? |
AndreFavotto
force-pushed
the
latest-beckhoff-ads
branch
from
d074d23 to
7e754bb
Compare
Contributor
|
@AndreFavotto We don't have anything "ready" to test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated Beckhoff-ADS to the latest tag. There are several updates since our last version (v22), and I see no real reason for keep using old versions. I might of course be wrong, so I am leaving this as a draft for now.
We can perform some tests on real hardware and check if everything is in place with the new version.
Build pipelines succeed, which is already a good sign.
From my looks into the library code I think we're good to go - and we want to get any latest bug fixes from Beckhoff - but I did not go through all changes.