Skip to content

Regroup Screens#158

Draft
shihab-dls wants to merge 9 commits intomainfrom
regroup_screens
Draft

Regroup Screens#158
shihab-dls wants to merge 9 commits intomainfrom
regroup_screens

Conversation

@shihab-dls
Copy link
Copy Markdown
Contributor

closes #154

@shihab-dls shihab-dls changed the title Regroup screens Regroup Screens Mar 11, 2026
@shihab-dls
Copy link
Copy Markdown
Contributor Author

simDetector, ADDriver, and NDArrayBase:
#154 (comment)

ADAravis:
image
image

@shihab-dls
Copy link
Copy Markdown
Contributor Author

Requires a new pvi release with Include and IgnoredSignals changes

@shihab-dls
Copy link
Copy Markdown
Contributor Author

Latest iteration:
Sim:
image
Aravis:
image

@shihab-dls
Copy link
Copy Markdown
Contributor Author

NDFileHDF5 Old:
image
P.S. This contains NDArrayBase changes, and thus the Advanced button.

New:
image
image
image
image

@shihab-dls
Copy link
Copy Markdown
Contributor Author

Latest iteration of screens:
Sim:
image
Aravis:
image
HDFPlugin:
image

Main changes are that we now have three main groups: Info, Consume, and Produce. Info generally should be a group for all read only data about status, Consume contains PVs from NDPluginBase, as this describes components involved in consuming arrays, and Produce contains PVs from NDFileHDF and NDArrayBase, as they deal with producing arrays.

@shihab-dls
Copy link
Copy Markdown
Contributor Author

@tomkane-dls, tagging you here for reference. The main PVI changes that are facilitating these screen changes are IgnoredComponent , and Include. Regrouping other plugins will probably follow how NDFileHDF has changed !

@gilesknap
Copy link
Copy Markdown
Member

@shihab-dls I have rebased over main with the shiny-should-be-fixed and way cooler CI.

I'm happy to merge this if you are.

@gilesknap
Copy link
Copy Markdown
Member

@shihab-dls does this mean that the device.yaml is now the source of truth? - so we can't re-run the converter again?

@gilesknap
Copy link
Copy Markdown
Member

@shihab-dls and now that the CI works gud, it looks like there is an issue with one of the device files in here? https://github.com/epics-containers/ibek-support/actions/runs/23334254664/job/67872104558

@tomkane-dls
Copy link
Copy Markdown
Contributor

So i think I'm continuing where @shihab-dls left this, and regrouping the screens for the other plugins. How am i deciding what should be in a subscreen? Based off of current EDM screens?

@shihab-dls
Copy link
Copy Markdown
Contributor Author

So i think I'm continuing where @shihab-dls left this, and regrouping the screens for the other plugins. How am i deciding what should be in a subscreen? Based off of current EDM screens?

Sorry, I should have provided more context. The current EDM screens and the mark rivers screens can be used as references, and generally if components can go into the top level Info and Consume groups (see NDFileHDF) they can be redefined there. I'm back from leave now, so I can take this back over if you'd like; if you're currently working on a screen, let me know, and we can do a hand over.

@shihab-dls
Copy link
Copy Markdown
Contributor Author

@shihab-dls does this mean that the device.yaml is now the source of truth? - so we can't re-run the converter again?

Yes, but if we do a reconvert instead, we will maintain the truth in the device.yaml, tacking on anything new, and merging anything already redefined. I'm a little concerned about how we handle component type changes upon a reconvert though, so I'll update this comment after discussing with @coretl

@shihab-dls
Copy link
Copy Markdown
Contributor Author

@shihab-dls and now that the CI works gud, it looks like there is an issue with one of the device files in here? https://github.com/epics-containers/ibek-support/actions/runs/23334254664/job/67872104558

This CI issssss pretty cool! And, yes, I've yet to make a new pvi release with the required new components used in the changes of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regroup areaDetector screens

3 participants