Draft
Conversation
gilesknap
force-pushed
the
devcontainer_interface
branch
from
580122e to
e9ca744
Compare
Member
|
@shihab-dls I've rebased this over main, hopefully fixing the CI. I think this is an important fix that we should get merged, but I wonder if it should supply a list of nic names? Some of our clusters have a mixture of nodes with different primary nic names (AFAIK). I assume this PR should include an update to ADAravis.build.yml too to pull in the new version of aravis support with the feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
interfaceNameentity to limit networks interfaces used when developing in devcontainer.