Skip to content

Conversation

@ephur
Copy link
Owner

@ephur ephur commented Dec 13, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the zsh configuration by adding support for UV (a fast Python package manager) and organizing common code utility paths. The changes integrate UV with proper XDG directory conventions and cache management, while also adding standard development tool paths to the system PATH.

Key changes:

  • Adds UV package manager configuration with XDG-compliant directory settings and shell completion caching
  • Adds ~/.local/bin to PATH for user-installed Python tools (pip, pipx, UV)
  • Adds VS Code CLI path for macOS

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
includes/late_50_tools.zsh Adds UV configuration block with cache/install directory detection and completion setup following existing patterns
includes/init.zsh Adds ~/.local/bin and VS Code macOS CLI paths to the standard PATH array

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

if [[ -n "${XDG_DATA_HOME}" ]]; then
export UV_PYTHON_INSTALL_DIR="${XDG_DATA_HOME}/uv/python"
elif (( IS_MACOS )); then
export UV_PYTHON_INSTALL_DIR="${HOME}/Library/Application Support/uv/python"
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UV_PYTHON_INSTALL_DIR path on macOS contains a space ("Application Support") which could cause issues in shell scripts if not properly quoted. While the variable itself is quoted here during export, downstream usage may not always quote it properly. Consider using a path without spaces, or ensure all downstream usages properly quote this variable.

Suggested change
export UV_PYTHON_INSTALL_DIR="${HOME}/Library/Application Support/uv/python"
export UV_PYTHON_INSTALL_DIR="${HOME}/Library/ApplicationSupport/uv/python"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants