Skip to content

Conversation

@ephur
Copy link
Owner

@ephur ephur commented Dec 12, 2025

This PR does... well a lot....

  1. I use work.zsh often as a dumping ground for new functions; this splits out non work specific ones into the general purpose includes
  2. Organize the cheetsheet by how tools are used, instead of how they are implemented
  3. Fixes all shellcheck warnings
  4. Adds a comprehensive test suite
  5. Sets up github actions to ensure tests pass

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR formalizes the zsh configuration project by adding comprehensive testing infrastructure, fixing shellcheck warnings, reorganizing documentation, and splitting general-purpose functions from work-specific ones. The changes establish a robust development workflow with automated CI/CD testing on GitHub Actions.

  • Adds comprehensive test suite (test_config.zsh) with syntax checking, linting, function validation, compilation tests, and performance benchmarking
  • Sets up GitHub Actions CI pipeline to run tests on Ubuntu and macOS for every push and pull request
  • Fixes all shellcheck warnings through proper quoting, variable declaration patterns, and zsh-specific syntax handling

Reviewed changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
.github/workflows/test.yml Adds CI pipeline for automated testing on Ubuntu and macOS
.github/CONTRIBUTING.md Comprehensive contribution guidelines including testing requirements and coding standards
tools/test_config.zsh Main test script with 6 test phases: syntax, shellcheck, load test, function existence, compilation, and performance
tools/pre-commit-hook Git hook integration for running quick tests before commits
tools/README.md Documentation for all testing and profiling tools
zshrc Refactors cache directory creation from compact form to explicit if/elif/else structure
includes/init.zsh Adds proper quoting to PATH manipulation functions
includes/early_*.zsh Fixes shellcheck warnings with proper quoting and command substitution
includes/late_15_git_functions.zsh Adds new git helper functions: gb, gca, glo, gnb with fzf integration
includes/late_20_aws_functions.zsh Adds awsp profile switcher and whoami-aws identity function
includes/late_25_kubernetes_functions.zsh Adds context/namespace switching and interactive pod management functions
includes/late_27_docker_functions.zsh New file with Docker helper functions for cleanup and interactive container management
includes/late_30_1password_functions.zsh Fixes quoting issues in op signin and item retrieval
includes/late_35_network_functions.zsh Adds port, myip, and httptest network utilities; fixes variable declarations in dq
includes/late_45_utility_functions.zsh Adds utility functions for archives, base64, timestamps, directory navigation, and process management
includes/late_46_format_functions.zsh New file with JSON/YAML conversion utilities: jpretty, y2j, j2y, jqp
includes/late_50_tools.zsh Adds shellcheck disable comment for zsh-specific &! syntax
includes/late_75_aliases.zsh Adds proper quoting around IS_WSL variable
includes/completions.zsh Adds proper quoting to LS_COLORS parameter expansion
README.md Updates performance target from sub-100ms to sub-150ms; adds CI badge
CHEATSHEET.md Major reorganization by tool usage instead of implementation; expands documentation for new functions
.gitignore Adds Claude settings file to gitignore

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ephur and others added 5 commits December 11, 2025 23:47
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ephur ephur merged commit e0d6d3e into master Dec 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants