Conversation
| end | ||
| } | ||
| new_es | ||
| def filter(tag, time, record) |
There was a problem hiding this comment.
Note: In v0.14, #filter is faster than #filter_stream because v0.14 makes filter pipeline: https://github.com/fluent/fluentd/blob/26c4dc4872b71665cd743c1d6b71c774429c750f/lib/fluent/event_router.rb#L214-L232
There was a problem hiding this comment.
How about replacing the body of the filter method with the body of the filter_record method?
It seems possible to delete redundant error handling.
https://github.com/fluent/fluentd/blob/161e1706273f2e9e179a0cc3d33e88a40dd60198/lib/fluent/plugin/filter.rb#L64-L66
There was a problem hiding this comment.
I've replaced it with the body of #filter_record.
|
I have not thought about the release of the new version yet, but before that, I'd like to think about migrating to a new configuration method.
|
Because string with `#split` makes the following a pitfall: ```aconf requires yaml, time <filter> filter "record.to_yaml; [Time.now.to_i, record]" </filter> ``` is not valid config. `requires yaml, time` will be interpreted as `['yaml', ' time']` and execute: ```ruby require 'yaml' require ' time' ``` This is because why string type with `#split` makes a some pitfall.
|
I've added commits which are reflected your review. |
|
Thanks for all your great work. |
|
How about using |
|
I think that's fine. |
|
Oh, I see.... Then, how about the following? <rule>
filter [something filtering config]
</rule>
<eval>
config [something evaluate instances]
</eval> |
2 participants
I've tried to migrate to use v0.14 Output and Filter Plugin API.
This PR contains major update change and also includes in breaking changes.
If above questions/problems are acceptable or reasonable for you, could you bump up major version if releasing new version of gem?
And please refer http://docs.fluentd.org/v0.14/articles/plugin-update-from-v12 before release new version.
Thanks in advance.